From 8a1758bf11c2d741e0cddc761b1dd2cdf564db93 Mon Sep 17 00:00:00 2001 From: Ryan Harrison Date: Tue, 15 Aug 2017 10:37:59 -0400 Subject: Remove GetAt from string classes This method duplicates the behaviour of the const [] operator and doesn't offer any additional safety. Folding them into one implementation. SetAt is retained, since implementing the non-const [] operator to replace SetAt has potential performance concerns. Specifically many non-obvious cases of reading an element using [] will cause a realloc & copy. BUG=pdfium:860 Change-Id: I3ef5e5e5a15376f040256b646eb0d90636e24b67 Reviewed-on: https://pdfium-review.googlesource.com/10870 Commit-Queue: Ryan Harrison Reviewed-by: Tom Sepez --- fxbarcode/oned/BC_OnedEAN8Writer.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'fxbarcode/oned/BC_OnedEAN8Writer.cpp') diff --git a/fxbarcode/oned/BC_OnedEAN8Writer.cpp b/fxbarcode/oned/BC_OnedEAN8Writer.cpp index 9a85f814a7..ae10fe52ef 100644 --- a/fxbarcode/oned/BC_OnedEAN8Writer.cpp +++ b/fxbarcode/oned/BC_OnedEAN8Writer.cpp @@ -70,7 +70,7 @@ CFX_WideString CBC_OnedEAN8Writer::FilterContents( CFX_WideString filtercontents; wchar_t ch; for (int32_t i = 0; i < contents.GetLength(); i++) { - ch = contents.GetAt(i); + ch = contents[i]; if (ch > 175) { i++; continue; -- cgit v1.2.3