From 36aae4fc09a353e01738bf0bbc302a21ba21ed07 Mon Sep 17 00:00:00 2001
From: Tom Sepez <tsepez@chromium.org>
Date: Mon, 4 Jun 2018 19:44:37 +0000
Subject: Make CJS_Objects track CJS_Runtime (and hence the document itself)

Precursor to removing some more v8::Context slot dependency.

There's a cost to maintaining the set of observers, but since these
objects are tied to V8 lifetimes, not C++ lifetimes, we want to be
very wary of the document going away unexpectedly.

Change-Id: I579f58a460aa50b88cb861227c9aca9a8a83ce12
Reviewed-on: https://pdfium-review.googlesource.com/33471
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
---
 fxjs/JS_Define.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

(limited to 'fxjs/JS_Define.h')

diff --git a/fxjs/JS_Define.h b/fxjs/JS_Define.h
index d9ab139374..325642d8ce 100644
--- a/fxjs/JS_Define.h
+++ b/fxjs/JS_Define.h
@@ -50,8 +50,8 @@ std::vector<v8::Local<v8::Value>> ExpandKeywordParams(
 
 template <class T>
 static void JSConstructor(CFXJS_Engine* pEngine, v8::Local<v8::Object> obj) {
-  auto pObj = pdfium::MakeUnique<T>(obj);
-  pObj->InitInstance(static_cast<CJS_Runtime*>(pEngine));
+  auto pObj = pdfium::MakeUnique<T>(obj, static_cast<CJS_Runtime*>(pEngine));
+  pObj->InitInstance();
   pEngine->SetObjectPrivate(obj, std::move(pObj));
 }
 
-- 
cgit v1.2.3