From 36aae4fc09a353e01738bf0bbc302a21ba21ed07 Mon Sep 17 00:00:00 2001 From: Tom Sepez Date: Mon, 4 Jun 2018 19:44:37 +0000 Subject: Make CJS_Objects track CJS_Runtime (and hence the document itself) Precursor to removing some more v8::Context slot dependency. There's a cost to maintaining the set of observers, but since these objects are tied to V8 lifetimes, not C++ lifetimes, we want to be very wary of the document going away unexpectedly. Change-Id: I579f58a460aa50b88cb861227c9aca9a8a83ce12 Reviewed-on: https://pdfium-review.googlesource.com/33471 Commit-Queue: Tom Sepez Reviewed-by: dsinclair --- fxjs/cfxjs_engine_unittest.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'fxjs/cfxjs_engine_unittest.cpp') diff --git a/fxjs/cfxjs_engine_unittest.cpp b/fxjs/cfxjs_engine_unittest.cpp index 5b93072935..64cd3a3e1e 100644 --- a/fxjs/cfxjs_engine_unittest.cpp +++ b/fxjs/cfxjs_engine_unittest.cpp @@ -43,7 +43,7 @@ TEST_F(FXJSEngineUnitTest, GC) { engine()->DefineObj("perm", FXJSOBJTYPE_DYNAMIC, [](CFXJS_Engine* pEngine, v8::Local obj) { pEngine->SetObjectPrivate( - obj, pdfium::MakeUnique(obj)); + obj, pdfium::MakeUnique(obj, nullptr)); perm_created = true; }, [](v8::Local obj) { @@ -55,7 +55,7 @@ TEST_F(FXJSEngineUnitTest, GC) { engine()->DefineObj("temp", FXJSOBJTYPE_DYNAMIC, [](CFXJS_Engine* pEngine, v8::Local obj) { pEngine->SetObjectPrivate( - obj, pdfium::MakeUnique(obj)); + obj, pdfium::MakeUnique(obj, nullptr)); temp_created = true; }, [](v8::Local obj) { -- cgit v1.2.3