From 304bb91238d6909cb5e170f8fc483aa7862558d5 Mon Sep 17 00:00:00 2001
From: tsepez <tsepez@chromium.org>
Date: Thu, 3 Nov 2016 06:10:26 -0700
Subject: Remove FX_BOOL entirely.

FX_BOOL was a type just like a regular C++ bool, except that it
took 4x the space and frequently was used to hold values besides
true or false.

Review-Url: https://codereview.chromium.org/2471353002
---
 fxjs/cfxjse_value.h | 54 ++++++++++++++++++++++++++---------------------------
 1 file changed, 27 insertions(+), 27 deletions(-)

(limited to 'fxjs/cfxjse_value.h')

diff --git a/fxjs/cfxjse_value.h b/fxjs/cfxjse_value.h
index 91819d81e4..487cf0c6e8 100644
--- a/fxjs/cfxjse_value.h
+++ b/fxjs/cfxjse_value.h
@@ -21,17 +21,17 @@ class CFXJSE_Value {
   explicit CFXJSE_Value(v8::Isolate* pIsolate);
   ~CFXJSE_Value();
 
-  FX_BOOL IsUndefined() const;
-  FX_BOOL IsNull() const;
-  FX_BOOL IsBoolean() const;
-  FX_BOOL IsString() const;
-  FX_BOOL IsNumber() const;
-  FX_BOOL IsInteger() const;
-  FX_BOOL IsObject() const;
-  FX_BOOL IsArray() const;
-  FX_BOOL IsFunction() const;
-  FX_BOOL IsDate() const;
-  FX_BOOL ToBoolean() const;
+  bool IsUndefined() const;
+  bool IsNull() const;
+  bool IsBoolean() const;
+  bool IsString() const;
+  bool IsNumber() const;
+  bool IsInteger() const;
+  bool IsObject() const;
+  bool IsArray() const;
+  bool IsFunction() const;
+  bool IsDate() const;
+  bool ToBoolean() const;
   FX_FLOAT ToFloat() const;
   double ToDouble() const;
   int32_t ToInteger() const;
@@ -43,7 +43,7 @@ class CFXJSE_Value {
 
   void SetUndefined();
   void SetNull();
-  void SetBoolean(FX_BOOL bBoolean);
+  void SetBoolean(bool bBoolean);
   void SetInteger(int32_t nInteger);
   void SetDouble(double dDouble);
   void SetString(const CFX_ByteStringC& szString);
@@ -55,22 +55,22 @@ class CFXJSE_Value {
   void SetArray(uint32_t uValueCount, CFXJSE_Value** rgValues);
   void SetDate(double dDouble);
 
-  FX_BOOL GetObjectProperty(const CFX_ByteStringC& szPropName,
+  bool GetObjectProperty(const CFX_ByteStringC& szPropName,
+                         CFXJSE_Value* lpPropValue);
+  bool SetObjectProperty(const CFX_ByteStringC& szPropName,
+                         CFXJSE_Value* lpPropValue);
+  bool GetObjectPropertyByIdx(uint32_t uPropIdx, CFXJSE_Value* lpPropValue);
+  bool SetObjectProperty(uint32_t uPropIdx, CFXJSE_Value* lpPropValue);
+  bool DeleteObjectProperty(const CFX_ByteStringC& szPropName);
+  bool HasObjectOwnProperty(const CFX_ByteStringC& szPropName,
+                            bool bUseTypeGetter);
+  bool SetObjectOwnProperty(const CFX_ByteStringC& szPropName,
                             CFXJSE_Value* lpPropValue);
-  FX_BOOL SetObjectProperty(const CFX_ByteStringC& szPropName,
-                            CFXJSE_Value* lpPropValue);
-  FX_BOOL GetObjectPropertyByIdx(uint32_t uPropIdx, CFXJSE_Value* lpPropValue);
-  FX_BOOL SetObjectProperty(uint32_t uPropIdx, CFXJSE_Value* lpPropValue);
-  FX_BOOL DeleteObjectProperty(const CFX_ByteStringC& szPropName);
-  FX_BOOL HasObjectOwnProperty(const CFX_ByteStringC& szPropName,
-                               FX_BOOL bUseTypeGetter);
-  FX_BOOL SetObjectOwnProperty(const CFX_ByteStringC& szPropName,
-                               CFXJSE_Value* lpPropValue);
-  FX_BOOL SetFunctionBind(CFXJSE_Value* lpOldFunction, CFXJSE_Value* lpNewThis);
-  FX_BOOL Call(CFXJSE_Value* lpReceiver,
-               CFXJSE_Value* lpRetValue,
-               uint32_t nArgCount,
-               CFXJSE_Value** lpArgs);
+  bool SetFunctionBind(CFXJSE_Value* lpOldFunction, CFXJSE_Value* lpNewThis);
+  bool Call(CFXJSE_Value* lpReceiver,
+            CFXJSE_Value* lpRetValue,
+            uint32_t nArgCount,
+            CFXJSE_Value** lpArgs);
 
   v8::Isolate* GetIsolate() const { return m_pIsolate; }
   const v8::Global<v8::Value>& DirectGetValue() const { return m_hValue; }
-- 
cgit v1.2.3