From 36aae4fc09a353e01738bf0bbc302a21ba21ed07 Mon Sep 17 00:00:00 2001 From: Tom Sepez Date: Mon, 4 Jun 2018 19:44:37 +0000 Subject: Make CJS_Objects track CJS_Runtime (and hence the document itself) Precursor to removing some more v8::Context slot dependency. There's a cost to maintaining the set of observers, but since these objects are tied to V8 lifetimes, not C++ lifetimes, we want to be very wary of the document going away unexpectedly. Change-Id: I579f58a460aa50b88cb861227c9aca9a8a83ce12 Reviewed-on: https://pdfium-review.googlesource.com/33471 Commit-Queue: Tom Sepez Reviewed-by: dsinclair --- fxjs/cjs_annot.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'fxjs/cjs_annot.h') diff --git a/fxjs/cjs_annot.h b/fxjs/cjs_annot.h index bbcf4ac178..cdb884f1b8 100644 --- a/fxjs/cjs_annot.h +++ b/fxjs/cjs_annot.h @@ -15,7 +15,7 @@ class CJS_Annot : public CJS_Object { static int GetObjDefnID(); static void DefineJSObjects(CFXJS_Engine* pEngine); - explicit CJS_Annot(v8::Local pObject); + CJS_Annot(v8::Local pObject, CJS_Runtime* pRuntime); ~CJS_Annot() override; void SetSDKAnnot(CPDFSDK_BAAnnot* annot) { m_pAnnot.Reset(annot); } -- cgit v1.2.3