From 36aae4fc09a353e01738bf0bbc302a21ba21ed07 Mon Sep 17 00:00:00 2001 From: Tom Sepez Date: Mon, 4 Jun 2018 19:44:37 +0000 Subject: Make CJS_Objects track CJS_Runtime (and hence the document itself) Precursor to removing some more v8::Context slot dependency. There's a cost to maintaining the set of observers, but since these objects are tied to V8 lifetimes, not C++ lifetimes, we want to be very wary of the document going away unexpectedly. Change-Id: I579f58a460aa50b88cb861227c9aca9a8a83ce12 Reviewed-on: https://pdfium-review.googlesource.com/33471 Commit-Queue: Tom Sepez Reviewed-by: dsinclair --- fxjs/cjs_app.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'fxjs/cjs_app.h') diff --git a/fxjs/cjs_app.h b/fxjs/cjs_app.h index e195c6db24..3c3a129641 100644 --- a/fxjs/cjs_app.h +++ b/fxjs/cjs_app.h @@ -20,7 +20,7 @@ class CJS_App : public CJS_Object { public: static void DefineJSObjects(CFXJS_Engine* pEngine); - explicit CJS_App(v8::Local pObject); + CJS_App(v8::Local pObject, CJS_Runtime* pRuntime); ~CJS_App() override; void TimerProc(GlobalTimer* pTimer); @@ -153,8 +153,8 @@ class CJS_App : public CJS_Object { void RunJsScript(CJS_Runtime* pRuntime, const WideString& wsScript); void ClearTimerCommon(CJS_Runtime* pRuntime, v8::Local param); - bool m_bCalculate; - bool m_bRuntimeHighLight; + bool m_bCalculate = true; + bool m_bRuntimeHighLight = false; std::set> m_Timers; }; -- cgit v1.2.3