From 36aae4fc09a353e01738bf0bbc302a21ba21ed07 Mon Sep 17 00:00:00 2001 From: Tom Sepez Date: Mon, 4 Jun 2018 19:44:37 +0000 Subject: Make CJS_Objects track CJS_Runtime (and hence the document itself) Precursor to removing some more v8::Context slot dependency. There's a cost to maintaining the set of observers, but since these objects are tied to V8 lifetimes, not C++ lifetimes, we want to be very wary of the document going away unexpectedly. Change-Id: I579f58a460aa50b88cb861227c9aca9a8a83ce12 Reviewed-on: https://pdfium-review.googlesource.com/33471 Commit-Queue: Tom Sepez Reviewed-by: dsinclair --- fxjs/cjs_document.cpp | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) (limited to 'fxjs/cjs_document.cpp') diff --git a/fxjs/cjs_document.cpp b/fxjs/cjs_document.cpp index 533decf1dc..3022519293 100644 --- a/fxjs/cjs_document.cpp +++ b/fxjs/cjs_document.cpp @@ -123,16 +123,13 @@ void CJS_Document::DefineJSObjects(CFXJS_Engine* pEngine) { DefineMethods(pEngine, ObjDefnID, MethodSpecs, FX_ArraySize(MethodSpecs)); } -CJS_Document::CJS_Document(v8::Local pObject) - : CJS_Object(pObject), - m_pFormFillEnv(nullptr), - m_cwBaseURL(L""), - m_bDelay(false) {} +CJS_Document::CJS_Document(v8::Local pObject, CJS_Runtime* pRuntime) + : CJS_Object(pObject, pRuntime) {} CJS_Document::~CJS_Document() = default; -void CJS_Document::InitInstance(IJS_Runtime* pIRuntime) { - SetFormFillEnv(pIRuntime->GetFormFillEnv()); +void CJS_Document::InitInstance() { + SetFormFillEnv(GetRuntime()->GetFormFillEnv()); } // The total number of fields in document. -- cgit v1.2.3