From dc5d88bcebbeeb696b405464e901add55d1efaf7 Mon Sep 17 00:00:00 2001 From: Dan Sinclair Date: Thu, 17 May 2018 13:53:52 +0000 Subject: Convert JS execute methods to return Optional This CL changes several of the JS execution methods to to return an Optional instead of a bool with a WideString out param. The IJS_Runtime::JS_Error will contain the line, column and exception message if an error occurs during execution. Change-Id: I37785ae6cd133a4c94ad8d25289473600b8a5d19 Reviewed-on: https://pdfium-review.googlesource.com/32614 Commit-Queue: dsinclair Reviewed-by: Tom Sepez --- fxjs/cjs_event_context_stub.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'fxjs/cjs_event_context_stub.cpp') diff --git a/fxjs/cjs_event_context_stub.cpp b/fxjs/cjs_event_context_stub.cpp index 0517ab2c49..82530e4c7b 100644 --- a/fxjs/cjs_event_context_stub.cpp +++ b/fxjs/cjs_event_context_stub.cpp @@ -6,7 +6,7 @@ #include "fxjs/cjs_event_context_stub.h" -bool CJS_EventContextStub::RunScript(const WideString& script, - WideString* info) { - return false; +Optional CJS_EventContextStub::RunScript( + const WideString& script) { + return IJS_Runtime::JS_Error(1, 1, L"JavaScript support not present"); } -- cgit v1.2.3