From 36aae4fc09a353e01738bf0bbc302a21ba21ed07 Mon Sep 17 00:00:00 2001 From: Tom Sepez Date: Mon, 4 Jun 2018 19:44:37 +0000 Subject: Make CJS_Objects track CJS_Runtime (and hence the document itself) Precursor to removing some more v8::Context slot dependency. There's a cost to maintaining the set of observers, but since these objects are tied to V8 lifetimes, not C++ lifetimes, we want to be very wary of the document going away unexpectedly. Change-Id: I579f58a460aa50b88cb861227c9aca9a8a83ce12 Reviewed-on: https://pdfium-review.googlesource.com/33471 Commit-Queue: Tom Sepez Reviewed-by: dsinclair --- fxjs/cjs_publicmethods.cpp | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'fxjs/cjs_publicmethods.cpp') diff --git a/fxjs/cjs_publicmethods.cpp b/fxjs/cjs_publicmethods.cpp index 6f49940494..b8d62b173a 100644 --- a/fxjs/cjs_publicmethods.cpp +++ b/fxjs/cjs_publicmethods.cpp @@ -205,10 +205,11 @@ bool IsValidSecond(int s) { } // namespace -CJS_PublicMethods::CJS_PublicMethods(v8::Local pObject) - : CJS_Object(pObject) {} +CJS_PublicMethods::CJS_PublicMethods(v8::Local pObject, + CJS_Runtime* pRuntime) + : CJS_Object(pObject, pRuntime) {} -CJS_PublicMethods::~CJS_PublicMethods() {} +CJS_PublicMethods::~CJS_PublicMethods() = default; // static void CJS_PublicMethods::DefineJSObjects(CFXJS_Engine* pEngine) { -- cgit v1.2.3