From 998fee395fc8a543968c7db3db9e3cf81dee57fc Mon Sep 17 00:00:00 2001 From: Dan Sinclair Date: Mon, 5 Feb 2018 21:43:19 +0000 Subject: Remove the CJS_EmbedObj template param from JSConstructor. Each of the CJS_Objects can create their CJS_EmbedObj's internally and we don't need to do it though the JSConstructor. This also removes the need for the SetEmbedObj method in CJS_Object. Change-Id: Ib0535ad922b370634fd1e622a04860a96c4f2825 Reviewed-on: https://pdfium-review.googlesource.com/25370 Reviewed-by: Tom Sepez Commit-Queue: dsinclair --- fxjs/cjs_report.cpp | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) (limited to 'fxjs/cjs_report.cpp') diff --git a/fxjs/cjs_report.cpp b/fxjs/cjs_report.cpp index 6af87a6fb9..a5e544151e 100644 --- a/fxjs/cjs_report.cpp +++ b/fxjs/cjs_report.cpp @@ -19,14 +19,18 @@ int CJS_Report::ObjDefnID = -1; // static void CJS_Report::DefineJSObjects(CFXJS_Engine* pEngine, FXJSOBJTYPE eObjType) { - ObjDefnID = pEngine->DefineObj( - "Report", eObjType, JSConstructor, JSDestructor); + ObjDefnID = pEngine->DefineObj("Report", eObjType, JSConstructor, + JSDestructor); DefineMethods(pEngine, ObjDefnID, MethodSpecs, FX_ArraySize(MethodSpecs)); } +CJS_Report::CJS_Report(v8::Local pObject) : CJS_Object(pObject) { + m_pEmbedObj = pdfium::MakeUnique(this); +} + Report::Report(CJS_Object* pJSObject) : CJS_EmbedObj(pJSObject) {} -Report::~Report() {} +Report::~Report() = default; CJS_Return Report::writeText(CJS_Runtime* pRuntime, const std::vector>& params) { -- cgit v1.2.3