From dc5d88bcebbeeb696b405464e901add55d1efaf7 Mon Sep 17 00:00:00 2001 From: Dan Sinclair Date: Thu, 17 May 2018 13:53:52 +0000 Subject: Convert JS execute methods to return Optional This CL changes several of the JS execution methods to to return an Optional instead of a bool with a WideString out param. The IJS_Runtime::JS_Error will contain the line, column and exception message if an error occurs during execution. Change-Id: I37785ae6cd133a4c94ad8d25289473600b8a5d19 Reviewed-on: https://pdfium-review.googlesource.com/32614 Commit-Queue: dsinclair Reviewed-by: Tom Sepez --- fxjs/cjs_runtime.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'fxjs/cjs_runtime.h') diff --git a/fxjs/cjs_runtime.h b/fxjs/cjs_runtime.h index c5e69fbdc8..0c32562304 100644 --- a/fxjs/cjs_runtime.h +++ b/fxjs/cjs_runtime.h @@ -37,7 +37,8 @@ class CJS_Runtime : public IJS_Runtime, IJS_EventContext* NewEventContext() override; void ReleaseEventContext(IJS_EventContext* pContext) override; CPDFSDK_FormFillEnvironment* GetFormFillEnv() const override; - int ExecuteScript(const WideString& script, WideString* info) override; + Optional ExecuteScript( + const WideString& script) override; CJS_EventContext* GetCurrentEventContext() const; -- cgit v1.2.3