From 0b2a9874bddf44b4226fcbafa9ce159a9b3735a8 Mon Sep 17 00:00:00 2001 From: weili Date: Wed, 21 Sep 2016 11:50:43 -0700 Subject: Set up isolate in CFXJS_Engine's constructor CFXJS_Engine class should always be constructed with an isolate, except for its subclasses which may need to create an isolate by themselves. Move SetIsolate() function to be protected so that only subclasses can access it. Review-Url: https://codereview.chromium.org/2354353002 --- fxjs/fxjs_v8.cpp | 2 ++ 1 file changed, 2 insertions(+) (limited to 'fxjs/fxjs_v8.cpp') diff --git a/fxjs/fxjs_v8.cpp b/fxjs/fxjs_v8.cpp index 5304254242..ebe38fdb7f 100644 --- a/fxjs/fxjs_v8.cpp +++ b/fxjs/fxjs_v8.cpp @@ -219,6 +219,8 @@ FXJS_PerIsolateData::FXJS_PerIsolateData() : m_pDynamicObjsMap(nullptr) {} CFXJS_Engine::CFXJS_Engine() : m_isolate(nullptr) {} +CFXJS_Engine::CFXJS_Engine(v8::Isolate* pIsolate) : m_isolate(pIsolate) {} + CFXJS_Engine::~CFXJS_Engine() { m_V8PersistentContext.Reset(); } -- cgit v1.2.3