From 1258f7f21725c703269581e0241fbad86d89209c Mon Sep 17 00:00:00 2001 From: Tom Sepez Date: Fri, 2 Feb 2018 17:37:37 +0000 Subject: Remove V8 context from CJS_V8 Makes CFXJS_Engine and CFXJSE_Engine consistent with each other in that both have a V8 context to themselves, and not one inheritted from the CJS_V8 (which is now more per-isolate than per-context). Consolidate NewLocalContext() and GetPersistentContext(), which both did the exact same thing under the covers once inside v8 land. Rename a few things to make it simpler. Change-Id: I68905db9ad44253063da235fcb276a75627a2dbc Reviewed-on: https://pdfium-review.googlesource.com/25170 Reviewed-by: dsinclair Commit-Queue: Tom Sepez --- fxjs/fxjs_v8.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'fxjs/fxjs_v8.h') diff --git a/fxjs/fxjs_v8.h b/fxjs/fxjs_v8.h index 0372ade9ce..851bdd5428 100644 --- a/fxjs/fxjs_v8.h +++ b/fxjs/fxjs_v8.h @@ -178,7 +178,6 @@ class CFXJS_Engine : public CJS_V8 { int Execute(const WideString& script, FXJSErr* perror); v8::Local GetThisObj(); - v8::Local NewFxDynamicObj(int nObjDefnID, bool bStatic = false); // Native object binding. @@ -189,10 +188,15 @@ class CFXJS_Engine : public CJS_V8 { void Error(const WideString& message); + v8::Local GetV8Context() { + return v8::Local::New(GetIsolate(), m_V8Context); + } + protected: CFXJS_Engine(); private: + v8::Global m_V8Context; std::vector*> m_StaticObjects; }; -- cgit v1.2.3