From 1258f7f21725c703269581e0241fbad86d89209c Mon Sep 17 00:00:00 2001 From: Tom Sepez Date: Fri, 2 Feb 2018 17:37:37 +0000 Subject: Remove V8 context from CJS_V8 Makes CFXJS_Engine and CFXJSE_Engine consistent with each other in that both have a V8 context to themselves, and not one inheritted from the CJS_V8 (which is now more per-isolate than per-context). Consolidate NewLocalContext() and GetPersistentContext(), which both did the exact same thing under the covers once inside v8 land. Rename a few things to make it simpler. Change-Id: I68905db9ad44253063da235fcb276a75627a2dbc Reviewed-on: https://pdfium-review.googlesource.com/25170 Reviewed-by: dsinclair Commit-Queue: Tom Sepez --- fxjs/fxjs_v8_embeddertest.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'fxjs/fxjs_v8_embeddertest.cpp') diff --git a/fxjs/fxjs_v8_embeddertest.cpp b/fxjs/fxjs_v8_embeddertest.cpp index 21e6460b8c..9e90663aa2 100644 --- a/fxjs/fxjs_v8_embeddertest.cpp +++ b/fxjs/fxjs_v8_embeddertest.cpp @@ -51,8 +51,8 @@ TEST_F(FXJSV8EmbedderTest, MultipleEngines) { CFXJS_Engine engine2(isolate()); engine2.InitializeEngine(); - v8::Local context1 = engine1.NewLocalContext(); - v8::Local context2 = engine2.NewLocalContext(); + v8::Local context1 = engine1.GetV8Context(); + v8::Local context2 = engine2.GetV8Context(); v8::Context::Scope context_scope(GetV8Context()); ExecuteInCurrentContext(WideString(kScript0)); -- cgit v1.2.3