From dc5d88bcebbeeb696b405464e901add55d1efaf7 Mon Sep 17 00:00:00 2001 From: Dan Sinclair Date: Thu, 17 May 2018 13:53:52 +0000 Subject: Convert JS execute methods to return Optional This CL changes several of the JS execution methods to to return an Optional instead of a bool with a WideString out param. The IJS_Runtime::JS_Error will contain the line, column and exception message if an error occurs during execution. Change-Id: I37785ae6cd133a4c94ad8d25289473600b8a5d19 Reviewed-on: https://pdfium-review.googlesource.com/32614 Commit-Queue: dsinclair Reviewed-by: Tom Sepez --- fxjs/ijs_event_context.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'fxjs/ijs_event_context.h') diff --git a/fxjs/ijs_event_context.h b/fxjs/ijs_event_context.h index 6050d65eca..8317bc29be 100644 --- a/fxjs/ijs_event_context.h +++ b/fxjs/ijs_event_context.h @@ -9,6 +9,8 @@ #include "core/fxcrt/fx_string.h" #include "core/fxcrt/fx_system.h" +#include "fxjs/ijs_runtime.h" +#include "third_party/base/optional.h" class CPDF_Bookmark; class CPDF_FormField; @@ -22,7 +24,8 @@ class IJS_EventContext { public: virtual ~IJS_EventContext() {} - virtual bool RunScript(const WideString& script, WideString* info) = 0; + virtual Optional RunScript( + const WideString& script) = 0; virtual void OnApp_Init() = 0; -- cgit v1.2.3