From 65b8db9a76b4b303d97836037b24b19e797fcd86 Mon Sep 17 00:00:00 2001 From: Lei Zhang Date: Wed, 10 Oct 2018 17:50:31 +0000 Subject: Remove non-const ref parameters in CPDF_IconFit. Also make methods const. Change-Id: I40a21d63fea30bbf37898cb57e1acc5ba8b3345f Reviewed-on: https://pdfium-review.googlesource.com/c/43792 Reviewed-by: Tom Sepez Commit-Queue: Lei Zhang --- fxjs/cjs_field.cpp | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) (limited to 'fxjs') diff --git a/fxjs/cjs_field.cpp b/fxjs/cjs_field.cpp index 2777fd8cf9..9c47e7033d 100644 --- a/fxjs/cjs_field.cpp +++ b/fxjs/cjs_field.cpp @@ -758,11 +758,8 @@ CJS_Result CJS_Field::get_button_align_x(CJS_Runtime* pRuntime) { return CJS_Result::Failure(JSMessage::kBadObjectError); CPDF_IconFit IconFit = pFormControl->GetIconFit(); - - float fLeft; - float fBottom; - IconFit.GetIconPosition(fLeft, fBottom); - return CJS_Result::Success(pRuntime->NewNumber(static_cast(fLeft))); + CFX_PointF pos = IconFit.GetIconBottomLeftPosition(); + return CJS_Result::Success(pRuntime->NewNumber(static_cast(pos.x))); } CJS_Result CJS_Field::set_button_align_x(CJS_Runtime* pRuntime, @@ -788,13 +785,8 @@ CJS_Result CJS_Field::get_button_align_y(CJS_Runtime* pRuntime) { return CJS_Result::Failure(JSMessage::kBadObjectError); CPDF_IconFit IconFit = pFormControl->GetIconFit(); - - float fLeft; - float fBottom; - IconFit.GetIconPosition(fLeft, fBottom); - - return CJS_Result::Success( - pRuntime->NewNumber(static_cast(fBottom))); + CFX_PointF pos = IconFit.GetIconBottomLeftPosition(); + return CJS_Result::Success(pRuntime->NewNumber(static_cast(pos.y))); } CJS_Result CJS_Field::set_button_align_y(CJS_Runtime* pRuntime, -- cgit v1.2.3