From 88dbd543bd0efe6acac20438037616e66b35e47b Mon Sep 17 00:00:00 2001 From: Tom Sepez Date: Fri, 12 Oct 2018 18:49:02 +0000 Subject: Add test for CJS_Color properties. Return a more precise error in one case. Change-Id: I21e4ef6b30be5f44d35922640643bffb9cb4b5e4 Reviewed-on: https://pdfium-review.googlesource.com/c/43950 Reviewed-by: Lei Zhang Commit-Queue: Tom Sepez --- fxjs/cjs_color.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'fxjs') diff --git a/fxjs/cjs_color.cpp b/fxjs/cjs_color.cpp index bba4513b67..06c61f87d4 100644 --- a/fxjs/cjs_color.cpp +++ b/fxjs/cjs_color.cpp @@ -258,9 +258,12 @@ CJS_Result CJS_Color::GetPropertyHelper(CJS_Runtime* pRuntime, CFX_Color* var) { CJS_Result CJS_Color::SetPropertyHelper(CJS_Runtime* pRuntime, v8::Local vp, CFX_Color* var) { - if (vp.IsEmpty() || !vp->IsArray()) + if (vp.IsEmpty()) return CJS_Result::Failure(JSMessage::kParamError); + if (!vp->IsArray()) + return CJS_Result::Failure(JSMessage::kTypeError); + *var = ConvertArrayToPWLColor(pRuntime, pRuntime->ToArray(vp)); return CJS_Result::Success(); } -- cgit v1.2.3