From d1f792ac1ba25494b44e664d4a427127299d05e6 Mon Sep 17 00:00:00 2001 From: Tom Sepez Date: Thu, 19 Mar 2015 12:51:04 -0700 Subject: Fix subtle issues in opj_skip_from_memory and add unit tests. Follow on to https://codereview.chromium.org/990683002/. This more closely mimics what fseek() actually does, so as to avoid subtle bugs down the road. Move the DecodeData struct into a header so the test can use it, and provide a constructor for it. Along the way, I added include guards, removed the p_ prefix from some non-pointer vars, fixed some IWYU, and resolved some signed/unsigned comparison warnings with careful casting. BUG=452671 R=jun_fang@foxitsoftware.com, thestig@chromium.org Review URL: https://codereview.chromium.org/1016203002 --- pdfium.gyp | 1 + 1 file changed, 1 insertion(+) (limited to 'pdfium.gyp') diff --git a/pdfium.gyp b/pdfium.gyp index 4134b49f8d..d22375f18a 100644 --- a/pdfium.gyp +++ b/pdfium.gyp @@ -837,6 +837,7 @@ ], 'sources': [ 'core/src/fpdfapi/fpdf_parser/fpdf_parser_decode_unittest.cpp', + 'core/src/fxcodec/codec/fx_codec_jpx_unittest.cpp', 'core/src/fxcrt/fx_basic_bstring_unittest.cpp', 'core/src/fxcrt/fx_basic_wstring_unittest.cpp', 'testing/fx_string_testhelpers.h', -- cgit v1.2.3