From 74b91b279d0dee175c2e461ffa4fcc7fe5002a6e Mon Sep 17 00:00:00 2001 From: Tom Sepez Date: Fri, 16 Jan 2015 08:55:17 -0800 Subject: Follow-on to pdfium_embeddertests. This includes: - Fix TestLoader lifetime. - Rename test file to match the equivalent .cpp under test - Re-organize a few tests to avoid duplicate loading - add tests for a few additional functions. R=jam@chromium.org Review URL: https://codereview.chromium.org/857483005 --- testing/embedder_test.cpp | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) (limited to 'testing/embedder_test.cpp') diff --git a/testing/embedder_test.cpp b/testing/embedder_test.cpp index 7b8498345a..e823347ef1 100644 --- a/testing/embedder_test.cpp +++ b/testing/embedder_test.cpp @@ -195,6 +195,9 @@ void EmbedderTest::SetUp() { void EmbedderTest::TearDown() { FPDF_CloseDocument(document_); FPDFAvail_Destroy(avail_); + if (loader_) { + delete loader_; + } if (file_contents_) { free(file_contents_); } @@ -206,11 +209,10 @@ bool EmbedderTest::OpenDocument(const std::string& filename) { return false; } - TestLoader loader(file_contents_, file_length_); - + loader_ = new TestLoader(file_contents_, file_length_); file_access_.m_FileLen = static_cast(file_length_); file_access_.m_GetBlock = Get_Block; - file_access_.m_Param = &loader; + file_access_.m_Param = loader_; file_avail_.version = 1; file_avail_.IsDataAvail = Is_Data_Avail; -- cgit v1.2.3