From 5553d8b11634935c34e7774325eda6afd61c8f56 Mon Sep 17 00:00:00 2001 From: Dan Sinclair Date: Wed, 3 Jan 2018 09:44:28 -0500 Subject: Initialize V8 once in embedder tests This CL moves the initialization of the V8 platform to happen in the GTest environment so it's only run once. This takes the CFXJSE_FormCalcContextEmbedderTest Debug time from ~25s to ~19s on my local machine. Bug: pdfium:928 Change-Id: Ie8c27606721e7056de42e7d9474b0621f1e7212f Reviewed-on: https://pdfium-review.googlesource.com/22070 Reviewed-by: Tom Sepez Commit-Queue: dsinclair --- testing/embedder_test.h | 3 --- 1 file changed, 3 deletions(-) (limited to 'testing/embedder_test.h') diff --git a/testing/embedder_test.h b/testing/embedder_test.h index 03155793c5..8da1643824 100644 --- a/testing/embedder_test.h +++ b/testing/embedder_test.h @@ -167,9 +167,6 @@ class EmbedderTest : public ::testing::Test, FPDF_FORMHANDLE form_handle_; FPDF_AVAIL avail_; FPDF_FILEACCESS file_access_; // must outlive avail_. -#ifdef PDF_ENABLE_V8 - v8::Platform* platform_; -#endif // PDF_ENABLE_V8 void* external_isolate_; TestLoader* loader_; size_t file_length_; -- cgit v1.2.3