From a76f557650dfc95cae5f535d4a1b627a84d2b5f0 Mon Sep 17 00:00:00 2001 From: Tom Sepez Date: Tue, 2 Jun 2015 16:51:07 -0700 Subject: Automated test case for 487928. Reproducing this bug requires the embedder to fire timers, something the single-pass pdfium-test binary doesn't do properly at the present. So we modify the embedder test delegate to allow the immediate triggering of the same. Perform some cleanup along the way by removing EmbedderTestDefaultDelegate -- it buys us nothing over the the no-op one. And, of course, v8 initialization is busted again, and we need v8 here. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1153213004 --- testing/embedder_test.h | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) (limited to 'testing/embedder_test.h') diff --git a/testing/embedder_test.h b/testing/embedder_test.h index 5cede6c6b4..b0834ddecd 100644 --- a/testing/embedder_test.h +++ b/testing/embedder_test.h @@ -36,6 +36,12 @@ class EmbedderTest : public ::testing::Test, int type, int icon) { return 0; } + + // Equivalent to FPDF_FORMFILLINFO::FFI_SetTimer(). + virtual int SetTimer(int msecs, TimerCallback fn) { return 0; } + + // Equivalent to FPDF_FORMFILLINFO::FFI_KillTimer(). + virtual void KillTimer(int id) { } }; EmbedderTest(); @@ -81,6 +87,7 @@ class EmbedderTest : public ::testing::Test, FX_DOWNLOADHINTS hints_; FPDF_FILEACCESS file_access_; FX_FILEAVAIL file_avail_; + v8::Platform* platform_; v8::StartupData natives_; v8::StartupData snapshot_; TestLoader* loader_; @@ -91,7 +98,9 @@ class EmbedderTest : public ::testing::Test, static void UnsupportedHandlerTrampoline(UNSUPPORT_INFO*, int type); static int AlertTrampoline(IPDF_JSPLATFORM* plaform, FPDF_WIDESTRING message, FPDF_WIDESTRING title, int type, int icon); + static int SetTimerTrampoline(FPDF_FORMFILLINFO* info, int msecs, + TimerCallback fn); + static void KillTimerTrampoline(FPDF_FORMFILLINFO* info, int id); }; #endif // TESTING_EMBEDDER_TEST_H_ - -- cgit v1.2.3