From d5d48457dabbe71e7f6b0baf2eaea6aa0dc86736 Mon Sep 17 00:00:00 2001 From: Ryan Harrison Date: Wed, 9 May 2018 20:31:12 +0000 Subject: Do not build PNG when codec is disabled Currently all of the PNG related code is being built when support for the codec is disabled, it just isn't being utilized. Depending on the settings being used, this unneeded code may or may not get stripped during linking. This CL explicitly turns off building the PNG codec code if support for PNG is turned off. BUG=pdfium:1080 Change-Id: I9c5247145fcadbcb1bd2243aa83350304ba421ff Reviewed-on: https://pdfium-review.googlesource.com/32270 Reviewed-by: Tom Sepez Commit-Queue: Ryan Harrison --- testing/libfuzzer/BUILD.gn | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) (limited to 'testing/libfuzzer/BUILD.gn') diff --git a/testing/libfuzzer/BUILD.gn b/testing/libfuzzer/BUILD.gn index a45c8d2576..5a050a2237 100644 --- a/testing/libfuzzer/BUILD.gn +++ b/testing/libfuzzer/BUILD.gn @@ -42,12 +42,14 @@ group("libfuzzer") { ":pdf_codec_bmp_fuzzer", ":pdf_codec_gif_fuzzer", ":pdf_codec_jpeg_fuzzer", - ":pdf_codec_png_fuzzer", ":pdf_css_fuzzer", ":pdf_fm2js_fuzzer", ":pdf_formcalc_fuzzer", ":pdf_lzw_fuzzer", ] + if (pdf_enable_xfa_png) { + deps += [ ":pdf_codec_png_fuzzer" ] + } if (pdf_enable_xfa_tiff) { deps += [ ":pdf_codec_tiff_fuzzer" ] } @@ -100,11 +102,13 @@ if (pdf_enable_xfa) { ] } - pdfium_fuzzer("pdf_codec_png_fuzzer") { - sources = [ - "pdf_codec_png_fuzzer.cc", - "xfa_codec_fuzzer.h", - ] + if (pdf_enable_xfa_png) { + pdfium_fuzzer("pdf_codec_png_fuzzer") { + sources = [ + "pdf_codec_png_fuzzer.cc", + "xfa_codec_fuzzer.h", + ] + } } if (pdf_enable_xfa_tiff) { -- cgit v1.2.3