From 6bdd824188bc9a2e6b24b5752a3170ce10185c1d Mon Sep 17 00:00:00 2001 From: Wei Li Date: Thu, 23 Mar 2017 09:45:04 -0700 Subject: Fix two CloneNonCycle issues CloneNonCycle() tries to detect cyclic object references without copying them. There are two issues: -- for elements in an array or a dictionary, they should be able to refer to the same object, which are not cyclic; -- for cyclic referenced elements in an array or a dictionary, do not clone the element at all. Having nullptr or as an element, like we did before, might cause crash when the element being accessed. BUG=chromium:701860 Change-Id: Id0304accde76ed06fa5ce640994c7628359600fb Reviewed-on: https://pdfium-review.googlesource.com/3156 Commit-Queue: dsinclair Reviewed-by: dsinclair --- testing/resources/circular_viewer_ref.in | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) create mode 100644 testing/resources/circular_viewer_ref.in (limited to 'testing/resources/circular_viewer_ref.in') diff --git a/testing/resources/circular_viewer_ref.in b/testing/resources/circular_viewer_ref.in new file mode 100644 index 0000000000..f791607e91 --- /dev/null +++ b/testing/resources/circular_viewer_ref.in @@ -0,0 +1,24 @@ +{{header}} +{{object 1 0}} +<> + >>>> +>> +endobj + +{{object 2 0}} +<> +endobj + +{{object 7 0}} +<> +endobj + +{{xref}} +trailer <> +{{startxref}} +%%EOF -- cgit v1.2.3