From b6b01cb2cbaf6b38736f4dfebb9b6cdc243960f9 Mon Sep 17 00:00:00 2001 From: Tom Sepez Date: Wed, 20 Jun 2018 16:10:13 +0000 Subject: Re-work some more c_str() usage. Many of these are converting ByteString => c_str => ByteStringView, since the ByteStringView ctor is implicit. This is unfortunate, since that involves a strlen() which the ByteString already knows if we use AsStringView() instead. This changed one test result where we can now return the string "\0" instead of "" -- since strlen no longer eats the NUL. This seems consistent, say, with String.fromCharCode(). Change-Id: I17f68d1a1f4b352960208f9148e68ab4c4d78bd2 Reviewed-on: https://pdfium-review.googlesource.com/35590 Reviewed-by: dsinclair Commit-Queue: Tom Sepez --- testing/resources/javascript/util_bytetochar_expected.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'testing/resources/javascript') diff --git a/testing/resources/javascript/util_bytetochar_expected.txt b/testing/resources/javascript/util_bytetochar_expected.txt index df15ee7226..487b89c523 100644 --- a/testing/resources/javascript/util_bytetochar_expected.txt +++ b/testing/resources/javascript/util_bytetochar_expected.txt @@ -1,4 +1,4 @@ -Alert: 0 => +Alert: 0 => 0 Alert: 65 => 65 Alert: 127 => 127 Alert: 128 => 128 -- cgit v1.2.3