From 6e369c2ebb4769a42736b32154c0de12b73df45d Mon Sep 17 00:00:00 2001 From: Tom Sepez Date: Mon, 31 Aug 2015 14:44:21 -0700 Subject: Fix two issues shown by bug 489995 - Handle NULL in buffer operator<< under JS mailForm() calls. - Ensure correct type in JS addIcon() calls. BUG=489995 R=brucedawson@chromium.org, thestig@chromium.org Review URL: https://codereview.chromium.org/1327473002 . --- testing/resources/javascript/document_methods.in | 1 + testing/resources/javascript/document_methods_expected.txt | 1 + 2 files changed, 2 insertions(+) (limited to 'testing/resources') diff --git a/testing/resources/javascript/document_methods.in b/testing/resources/javascript/document_methods.in index b2467f37c4..3cd3330b87 100644 --- a/testing/resources/javascript/document_methods.in +++ b/testing/resources/javascript/document_methods.in @@ -122,6 +122,7 @@ function testAddIcon() { // Second argument must actually be an icon. expectError('this.addIcon("myicon", 3)'); + expectError('this.addIcon("myicon", undefined)'); // TODO(tsepez): test success cases. } diff --git a/testing/resources/javascript/document_methods_expected.txt b/testing/resources/javascript/document_methods_expected.txt index 753a99df6e..26f7b542dd 100644 --- a/testing/resources/javascript/document_methods_expected.txt +++ b/testing/resources/javascript/document_methods_expected.txt @@ -77,6 +77,7 @@ Alert: PASS: this.addIcon() threw error Document.addIcon: Incorrect number of pa Alert: PASS: this.addIcon(1) threw error Document.addIcon: Incorrect number of parameters passed to function. Alert: PASS: this.addIcon(1, 2, 3) threw error Document.addIcon: Incorrect number of parameters passed to function. Alert: PASS: this.addIcon("myicon", 3) threw error Document.addIcon: Incorrect parameter type. +Alert: PASS: this.addIcon("myicon", undefined) threw error Document.addIcon: Incorrect parameter type. Alert: PASS: typeof this.calculateNow = function Alert: PASS: typeof this.getField = function Alert: PASS: this.getField() threw error Document.getField: Incorrect number of parameters passed to function. -- cgit v1.2.3