From fb0e3d754db6980d1c8224f7b38070c12ac9eaea Mon Sep 17 00:00:00 2001 From: dsinclair Date: Wed, 20 Apr 2016 07:05:28 -0700 Subject: Revert of Re-Reland Combined test runner. (patchset #4 id:80001 of https://codereview.chromium.org/1888673003/ ) Reason for revert: Dr.Memory code is wrong..... Original issue's description: > Re-Reland Combined test runner. > > Original Commit Message: > > This CL revives the old CL to combine the test runners [1] which was reverted > due to failing font_size tests. I've deleted the font_size.pdf as it is not > needed and for testing. Pixel tests are either .in or .pdf files, not both. > > Original description: > This CL takes the three test runners (corpus, javascript, pixel) and combines > the code into a single test_runner file. Each of the individual runners still > exists and calls the test runner with their data directory. > > With this change, the pixel and javascript test will now run in parallel if > multiple processors are available. > > 1-https://codereview.chromium.org/1430623006/ > > BUG= > > Committed: https://pdfium.googlesource.com/pdfium/+/84b26ec6ba8193235ce0df817dec5c0f1da29841 TBR=ochang@chromium.org,zhaoqin@chromium.org,tsepez@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1898353004 --- testing/tools/common.py | 8 -------- 1 file changed, 8 deletions(-) (limited to 'testing/tools/common.py') diff --git a/testing/tools/common.py b/testing/tools/common.py index ce292bf41f..6e9de7c82c 100755 --- a/testing/tools/common.py +++ b/testing/tools/common.py @@ -18,13 +18,6 @@ def os_name(): raise Exception('Confused, can not determine OS, aborting.') -def RunCommandToFile(cmd, file): - try: - subprocess.check_call(cmd, stdout=file) - return None - except subprocess.CalledProcessError as e: - return e - def RunCommand(cmd, redirect_output=False): try: if redirect_output: @@ -35,7 +28,6 @@ def RunCommand(cmd, redirect_output=False): except subprocess.CalledProcessError as e: return e - # Adjust Dr. Memory wrapper to have separate log directory for each test # for better error reporting. def DrMemoryWrapper(wrapper, pdf_name): -- cgit v1.2.3