From a7b65b85bba95fb8757cbd407fd38d71304128ab Mon Sep 17 00:00:00 2001 From: Ryan Harrison Date: Wed, 30 May 2018 19:56:11 +0000 Subject: Migrate coverage_report.py to use upstream Chromium scripts This adds tools/code_coverage from Chromium to DEPS and converts our existing coverage_report.py to use it instead of gcov & lcov. This generates a different format of HTML report, but the content appears to be the same. Some of the coverage numbers changed a bit, due to differences in how llvm-cov and gcov calculate executable lines, but drilling down into the reports I think llvm-cov is more accurate overall and there are no major discrepancies. Large portions of the existing script are left as is and just the report generation has been changed. I plan in follow up CLs to remove the duplication of functionality in the PDFium scripts and modularlize the upstream code better. BUG=pdfium:1069 Change-Id: I009bfb8aac8f1a878e01ff70923e19bbb4774a9c Reviewed-on: https://pdfium-review.googlesource.com/32894 Commit-Queue: Ryan Harrison Reviewed-by: dsinclair Reviewed-by: Lei Zhang --- testing/tools/coverage/llvm-gcov | 15 --------------- 1 file changed, 15 deletions(-) delete mode 100755 testing/tools/coverage/llvm-gcov (limited to 'testing/tools/coverage/llvm-gcov') diff --git a/testing/tools/coverage/llvm-gcov b/testing/tools/coverage/llvm-gcov deleted file mode 100755 index 8141e7ef27..0000000000 --- a/testing/tools/coverage/llvm-gcov +++ /dev/null @@ -1,15 +0,0 @@ -#!/bin/bash -# Copyright 2017 The PDFium Authors. All rights reserved. -# Use of this source code is governed by a BSD-style license that can be -# found in the LICENSE file. - -# Wrapper script to make llvm-cov behave like gcov, so it can be passed in as the --gcov-tool -# parameter when using lcov. Specifically adds the keyword 'gcov' to the arguments being passed in, -# to tell llvm-cov to operate in gcov compatibility mode. -# -# LLVM_COV_BIN needs to be set by caller and should the path to -# a llvm-cov binary with a version of 3.5 or greater. - -set -e - -exec ${LLVM_COV_BIN} gcov $* -- cgit v1.2.3