From 3b5cb78353f92ad7d23ace4e452ed26acf9aeaa7 Mon Sep 17 00:00:00 2001 From: dsinclair Date: Thu, 28 Apr 2016 06:17:40 -0700 Subject: Remove output redirect from corpus test runner. The corpus tests redirect output to a string but they just output it later anyway. This CL removes the output redirect and removes the redirect_output flag which will always be False now. Review-Url: https://codereview.chromium.org/1927633002 --- testing/tools/pngdiffer.py | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) (limited to 'testing/tools/pngdiffer.py') diff --git a/testing/tools/pngdiffer.py b/testing/tools/pngdiffer.py index 79d1b7588a..a1533b8329 100755 --- a/testing/tools/pngdiffer.py +++ b/testing/tools/pngdiffer.py @@ -38,8 +38,7 @@ class PNGDiffer(): i += 1 return actual_paths - def HasDifferences(self, input_filename, source_dir, working_dir, - redirect_output=False): + def HasDifferences(self, input_filename, source_dir, working_dir): template_paths = self._GetTemplatePaths( input_filename, source_dir, working_dir) actual_path_template = template_paths[0]; @@ -62,16 +61,14 @@ class PNGDiffer(): sys.stdout.flush() if os.path.exists(expected_path): error = common.RunCommand( - [self.pdfium_diff_path, expected_path, actual_path], - redirect_output) + [self.pdfium_diff_path, expected_path, actual_path]) else: error = 1; if error: # When failed, we check against platform based results. if os.path.exists(platform_expected_path): error = common.RunCommand( - [self.pdfium_diff_path, platform_expected_path, actual_path], - redirect_output) + [self.pdfium_diff_path, platform_expected_path, actual_path]) if error: print "FAILURE: " + input_filename + "; " + str(error) return True -- cgit v1.2.3