From 208eecfa7850ced5c0d776b9e5df5b104428608f Mon Sep 17 00:00:00 2001 From: Lei Zhang Date: Wed, 20 Dec 2017 19:40:50 +0000 Subject: Avoid default arguments in EmbedderTest::OpenDocument(). Default arguments are banned on virtual functions. Remove default arguments and rename OpenDocument() to OpenDocumentWithOptions(). Add wrappers for OpenDocumentWithOptions() to call it with sensible options. Change-Id: I4955d88cf77a7eab1771692ea3d6a18260b52900 Reviewed-on: https://pdfium-review.googlesource.com/21891 Commit-Queue: Lei Zhang Reviewed-by: Henrique Nakashima --- testing/xfa_js_embedder_test.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'testing/xfa_js_embedder_test.h') diff --git a/testing/xfa_js_embedder_test.h b/testing/xfa_js_embedder_test.h index 73d7d576a7..5f4549601c 100644 --- a/testing/xfa_js_embedder_test.h +++ b/testing/xfa_js_embedder_test.h @@ -22,12 +22,12 @@ class XFAJSEmbedderTest : public EmbedderTest { XFAJSEmbedderTest(); ~XFAJSEmbedderTest() override; + // EmbedderTest: void SetUp() override; void TearDown() override; - - bool OpenDocument(const std::string& filename, - const char* password = nullptr, - bool must_linearize = false) override; + bool OpenDocumentWithOptions(const std::string& filename, + const char* password, + bool must_linearize) override; v8::Isolate* GetIsolate() const { return isolate_; } CXFA_Document* GetXFADocument(); @@ -40,8 +40,8 @@ class XFAJSEmbedderTest : public EmbedderTest { private: std::unique_ptr array_buffer_allocator_; std::unique_ptr value_; - v8::Isolate* isolate_; - CFXJSE_Engine* script_context_; + v8::Isolate* isolate_ = nullptr; + CFXJSE_Engine* script_context_ = nullptr; bool ExecuteHelper(const ByteStringView& input); }; -- cgit v1.2.3