From 0b2a9874bddf44b4226fcbafa9ce159a9b3735a8 Mon Sep 17 00:00:00 2001 From: weili Date: Wed, 21 Sep 2016 11:50:43 -0700 Subject: Set up isolate in CFXJS_Engine's constructor CFXJS_Engine class should always be constructed with an isolate, except for its subclasses which may need to create an isolate by themselves. Move SetIsolate() function to be protected so that only subclasses can access it. Review-Url: https://codereview.chromium.org/2354353002 --- testing/js_embedder_test.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'testing') diff --git a/testing/js_embedder_test.cpp b/testing/js_embedder_test.cpp index f7aa7e38f7..125d2bff3e 100644 --- a/testing/js_embedder_test.cpp +++ b/testing/js_embedder_test.cpp @@ -21,8 +21,7 @@ void JSEmbedderTest::SetUp() { v8::Isolate::Scope isolate_scope(m_pIsolate); v8::HandleScope handle_scope(m_pIsolate); FXJS_PerIsolateData::SetUp(m_pIsolate); - m_Engine.reset(new CFXJS_Engine); - m_Engine->SetIsolate(m_pIsolate); + m_Engine.reset(new CFXJS_Engine(m_pIsolate)); m_Engine->InitializeEngine(); } -- cgit v1.2.3