From 33fdebc3da676bff84d0fd0f69b9087c0c12dfeb Mon Sep 17 00:00:00 2001 From: tsepez Date: Fri, 4 Nov 2016 11:38:40 -0700 Subject: Reland "Remove CPDF_Object::Release() in favor of direct delete" This reverts commit f0d5b6c35fa343108a3ab7a25bc2cc2b3cf105b3. Review-Url: https://codereview.chromium.org/2478303002 --- testing/libfuzzer/pdf_codec_jbig2_fuzzer.cc | 3 +-- testing/libfuzzer/pdf_hint_table_fuzzer.cc | 7 ++----- testing/libfuzzer/pdf_streamparser_fuzzer.cc | 2 +- 3 files changed, 4 insertions(+), 8 deletions(-) (limited to 'testing') diff --git a/testing/libfuzzer/pdf_codec_jbig2_fuzzer.cc b/testing/libfuzzer/pdf_codec_jbig2_fuzzer.cc index 9029775634..1db39751db 100644 --- a/testing/libfuzzer/pdf_codec_jbig2_fuzzer.cc +++ b/testing/libfuzzer/pdf_codec_jbig2_fuzzer.cc @@ -29,8 +29,7 @@ extern "C" int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) { if (!bitmap->Create(width, height, FXDIB_1bppRgb)) return 0; - std::unique_ptr> stream( - new CPDF_Stream); + std::unique_ptr stream(new CPDF_Stream); stream->AsStream()->SetData(data, size); CPDF_StreamAcc src_stream; src_stream.LoadAllData(stream->AsStream(), true); diff --git a/testing/libfuzzer/pdf_hint_table_fuzzer.cc b/testing/libfuzzer/pdf_hint_table_fuzzer.cc index 949605c0be..b01c87216b 100644 --- a/testing/libfuzzer/pdf_hint_table_fuzzer.cc +++ b/testing/libfuzzer/pdf_hint_table_fuzzer.cc @@ -82,13 +82,10 @@ extern "C" int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) { dummy_dict.primary_hint_stream_length = GetData(&data32, &data, &size); dummy_dict.shared_hint_table_offset = GetData(&data32, &data, &size); - CPDF_Dictionary* dummy_linearized_dict = new CPDF_Dictionary; - + std::unique_ptr dummy_linearized_dict(new CPDF_Dictionary); { - HintTableForFuzzing hint_table(&dummy_dict, dummy_linearized_dict); + HintTableForFuzzing hint_table(&dummy_dict, dummy_linearized_dict.get()); hint_table.Fuzz(data, size); } - - dummy_linearized_dict->Release(); return 0; } diff --git a/testing/libfuzzer/pdf_streamparser_fuzzer.cc b/testing/libfuzzer/pdf_streamparser_fuzzer.cc index 77580a91f8..a0287c935a 100644 --- a/testing/libfuzzer/pdf_streamparser_fuzzer.cc +++ b/testing/libfuzzer/pdf_streamparser_fuzzer.cc @@ -10,7 +10,7 @@ extern "C" int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) { CPDF_StreamParser parser(data, size); while (CPDF_Object* pObj = parser.ReadNextObject(true, 0)) - pObj->Release(); + delete pObj; return 0; } -- cgit v1.2.3