From a4941914bb4411dc4e9053cb344e0349db388007 Mon Sep 17 00:00:00 2001 From: tsepez Date: Mon, 15 Aug 2016 11:40:12 -0700 Subject: Move some v8 objects from CJS back into FXJS Create a new class to hold these, CFXJS_Engine (could have been called Runtime, but there are too many "Runtimes" already). In a subsequent patch, all the FXJS_*() functions that take an isolate as the first argument can become methods on the engine. CJS_ must still manage the isolates; this happens outside the engine. The IJS_Runtime abstraction moves up to fpdfsdk/javascript; it remains to allow for either a real JS library or a stubb one to be linked (for non-js builds). Review-Url: https://codereview.chromium.org/2241483004 --- testing/js_embedder_test.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'testing') diff --git a/testing/js_embedder_test.cpp b/testing/js_embedder_test.cpp index 5927d89af5..1b21fe04db 100644 --- a/testing/js_embedder_test.cpp +++ b/testing/js_embedder_test.cpp @@ -21,12 +21,12 @@ void JSEmbedderTest::SetUp() { v8::Isolate::Scope isolate_scope(m_pIsolate); v8::HandleScope handle_scope(m_pIsolate); FXJS_PerIsolateData::SetUp(m_pIsolate); - FXJS_InitializeRuntime(m_pIsolate, nullptr, &m_pPersistentContext, - &m_StaticObjects); + FXJS_InitializeEngine(m_pIsolate, nullptr, &m_pPersistentContext, + &m_StaticObjects); } void JSEmbedderTest::TearDown() { - FXJS_ReleaseRuntime(m_pIsolate, &m_pPersistentContext, &m_StaticObjects); + FXJS_ReleaseEngine(m_pIsolate, &m_pPersistentContext, &m_StaticObjects); m_pPersistentContext.Reset(); EmbedderTest::TearDown(); m_pIsolate->Dispose(); -- cgit v1.2.3