From b92ec18fdccd196035e02f3232c0b730637ac815 Mon Sep 17 00:00:00 2001 From: Henrique Nakashima Date: Wed, 11 Apr 2018 21:55:49 +0000 Subject: Fix crash when ColorSpace references itself directly. Also fixes any problems with cycles between colorspaces. Past fixes have solved problems with CPDF_DocPageData::GetColorSpace() calling itself and CPDF_DocPageData::GetColorSpace() calling CPDF_ColorSpace::Load() and vice versa. They have not solved CPDF_ColorSpace::Load() calling itself. This CL repurposes the |pVisited| set to ensure CPDF_ColorSpace::Load() does not try to load a colorspace as a dependency of itself and creates |pVisitedLocal| to ensure CPDF_DocPageData::GetColorSpace() does not create a similar circular dependency not involving CPDF_ColorSpace::Load(). Bug: chromium:828206 Change-Id: Ib2d0ec494be169135607f3651e0f70627b26ebd7 Reviewed-on: https://pdfium-review.googlesource.com/29810 Reviewed-by: Lei Zhang Commit-Queue: Henrique Nakashima --- testing/resources/bug_828206.pdf | Bin 0 -> 238 bytes 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 testing/resources/bug_828206.pdf (limited to 'testing') diff --git a/testing/resources/bug_828206.pdf b/testing/resources/bug_828206.pdf new file mode 100644 index 0000000000..7015f812bd Binary files /dev/null and b/testing/resources/bug_828206.pdf differ -- cgit v1.2.3