From 56569acb6daa4d487a3d3eccce5784028873651c Mon Sep 17 00:00:00 2001 From: Dan Sinclair Date: Thu, 30 Nov 2017 15:17:41 +0000 Subject: Run clang-tidy modernize-use-equals-{delete,default} on //third_party/pdfium See the bugs and cxx post for justification and details: https://groups.google.com/a/chromium.org/forum/#!topic/cxx/RkOHzIK6Tq8 This change was done using clang-tidy as described here: https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md In some cases the the tool leaves behind a string of commas where it replaced a member initializer list (https://bugs.llvm.org/show_bug.cgi?id=35051). They were cleaned up with: git diff --name-only | \ xargs sed -E -i 's/(^\s*|\)\s*):[ ,]*= default/\1 = default/' Bug: chromium:778959, chromium:778957 Change-Id: I23e60d3d6c8bc9e8574d425710a0441cb5510d6b Reviewed-on: https://pdfium-review.googlesource.com/19970 Reviewed-by: Lei Zhang Commit-Queue: dsinclair --- third_party/base/numerics/safe_math.h | 2 +- third_party/base/optional.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'third_party/base') diff --git a/third_party/base/numerics/safe_math.h b/third_party/base/numerics/safe_math.h index 8574fdd595..f24ba024eb 100644 --- a/third_party/base/numerics/safe_math.h +++ b/third_party/base/numerics/safe_math.h @@ -100,7 +100,7 @@ class CheckedNumeric { public: using type = T; - constexpr CheckedNumeric() {} + constexpr CheckedNumeric() = default; // Copy constructor. template diff --git a/third_party/base/optional.h b/third_party/base/optional.h index 4cf91e9b2b..ae25724e73 100644 --- a/third_party/base/optional.h +++ b/third_party/base/optional.h @@ -120,7 +120,7 @@ class Optional { public: using value_type = T; - constexpr Optional() {} + constexpr Optional() = default; constexpr Optional(nullopt_t) {} -- cgit v1.2.3