From 0630447196b898b60103ca634e5c9d034b9d24d1 Mon Sep 17 00:00:00 2001 From: Nicolas Pena Date: Thu, 26 Jan 2017 15:45:02 -0500 Subject: Fix leak in PredictorSetupDecode by calling tif_cleanup on failure MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit tif_data and tif_cleanup are both set on the TIFFInit methods, see for instance TIFFInitPixarLog. If PredictorSetupDecode fails, whatever was filled on tif_data should be cleaned up. The previous leak fix from PixarLogSetupDecode is no longer necessary. BUG=683834 Change-Id: Ib7dec3fb8addd56fa20f2e85c4ee918222a5f97e Reviewed-on: https://pdfium-review.googlesource.com/2432 Reviewed-by: Tom Sepez Commit-Queue: Nicolás Peña --- third_party/libtiff/README.pdfium | 1 + 1 file changed, 1 insertion(+) (limited to 'third_party/libtiff/README.pdfium') diff --git a/third_party/libtiff/README.pdfium b/third_party/libtiff/README.pdfium index 04f728e3f7..7057a58a87 100644 --- a/third_party/libtiff/README.pdfium +++ b/third_party/libtiff/README.pdfium @@ -27,3 +27,4 @@ Local Modifications: 0015-fix-leaks-in-tif_ojpeg.patch: fix direct leaks in tif_ojpeg.c methods 0016-fix-leak-in-pixarlogsetupdecode.patch: Free sp->tbuf if setup fails 0017-safe_skews_in_gtTileContig.patch: return error if to/from skews overflow from int32. +0018-fix-leak-in-PredictorSetupDecode.patch: call tif->tif_cleanup if the setup fails. -- cgit v1.2.3