From dc36f99188feec82454f62d5f489f358dc5fd9c1 Mon Sep 17 00:00:00 2001 From: Vlad Tsyrklevich Date: Thu, 4 Jan 2018 16:39:45 -0800 Subject: Reland "[CFI] Enable type generalization for LCMS" This relands commit 7829b7048d5cf13a4f1a806fed57f2440d1b5dec. This uses a new version of clang with a fix for the LSan issue that caused the previous revert. Original change's description: > [CFI] Enable type generalization for LCMS > > Control Flow Integrity [1] indirect call checking verifies that function > pointers only call valid functions with a matching type signature. This > condition can be too strict, a common form of 'abstraction' relies on > function pointers being cast to generalize argument pointer types to > void*. > > In LCMS these failures occur because of casts of function pointers called > as both _cmsInterpFn16 (cmsInterpFunction.Lerp16) and _cmsOPTeval16Fn (as > an argument to _cmsPipelineSetOptimizationParameters) types making it > difficult to refactor out easily. Instead, enabling the type > generalization build config weakens the type checking performed for > CFI-icall to accomodate this common type of casts. > > [1] https://www.chromium.org/developers/testing/control-flow-integrity > > Bug: 785442 > Change-Id: Ib42fb1b4e152d5042b170698c2707ebb9e0cc1ee > Reviewed-on: https://pdfium-review.googlesource.com/19250 > Commit-Queue: dsinclair > Reviewed-by: dsinclair Bug: 785442 Change-Id: Ice696e4f496fa380f8af053577bde7e46c049590 Reviewed-on: https://pdfium-review.googlesource.com/22265 Reviewed-by: dsinclair Commit-Queue: dsinclair --- third_party/BUILD.gn | 1 + 1 file changed, 1 insertion(+) (limited to 'third_party') diff --git a/third_party/BUILD.gn b/third_party/BUILD.gn index e0874ea570..d9f7670bb5 100644 --- a/third_party/BUILD.gn +++ b/third_party/BUILD.gn @@ -249,6 +249,7 @@ static_library("fx_lcms2") { configs -= [ "//build/config/compiler:chromium_code" ] configs += [ "//build/config/compiler:no_chromium_code", + "//build/config/sanitizers:cfi_icall_generalize_pointers", ":pdfium_third_party_config", # Must be after no_chromium_code for warning flags to be ordered correctly. -- cgit v1.2.3