From 3a005f22703b9303a306bf34cbd17c3729f763aa Mon Sep 17 00:00:00 2001 From: tsepez Date: Fri, 27 May 2016 17:45:00 -0700 Subject: Workaround dubious casting between CXFA_Object and void* in FXJSE This is just a crock to get things working until we fix the underlying issue. When there's single-inheritance, it may often work in practice to C-style (reinterpret) cast a Derived* ptr to void* and then back to a Base* ptr. One place where this blows up is if Derived has virtual functions but Base does not, in which case the world will be offset by the size of a vtable ptr. Because of the use of void* types in FXJSE, the above was happening when setting a CXFA_ThisProxy (Derived, virtual) to be a global object (void*). This would then be cast back to a CFXA_Object (Base, non-virtual) and chaos is ensured. Not sure how far back this goes. Along the way, pick up some tidying which was necessary for simplicity while tracking this down. BUG=613607 Review-Url: https://codereview.chromium.org/2015143005 --- xfa.gyp | 1 - 1 file changed, 1 deletion(-) (limited to 'xfa.gyp') diff --git a/xfa.gyp b/xfa.gyp index 14a813096b..82b88c9591 100644 --- a/xfa.gyp +++ b/xfa.gyp @@ -722,7 +722,6 @@ "xfa/fxjse/runtime.cpp", "xfa/fxjse/runtime.h", "xfa/fxjse/scope_inline.h", - "xfa/fxjse/util_inline.h", "xfa/fxjse/value.cpp", "xfa/fxjse/value.h" ], -- cgit v1.2.3