From 530c7acf7aa11ff8db8743af0d62b39cf36bf539 Mon Sep 17 00:00:00 2001 From: tsepez Date: Tue, 25 Oct 2016 14:36:49 -0700 Subject: Avoid dubious use of comma operator in fde_csssyntax.h Review-Url: https://codereview.chromium.org/2446113005 --- xfa/fde/css/fde_csssyntax.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'xfa/fde/css') diff --git a/xfa/fde/css/fde_csssyntax.h b/xfa/fde/css/fde_csssyntax.h index 294dfcb540..af1d444144 100644 --- a/xfa/fde/css/fde_csssyntax.h +++ b/xfa/fde/css/fde_csssyntax.h @@ -22,11 +22,11 @@ class CFDE_CSSTextBuf : public CFX_Target { int32_t iStreamOffset, int32_t iMaxChars, FX_BOOL& bEOS); - FX_BOOL AppendChar(FX_WCHAR wch) { - if (m_iDatLen >= m_iBufLen && !ExpandBuf(m_iBufLen * 2)) { - return FALSE; - } - return (m_pBuffer[m_iDatLen++] = wch), TRUE; + bool AppendChar(FX_WCHAR wch) { + if (m_iDatLen >= m_iBufLen && !ExpandBuf(m_iBufLen * 2)) + return false; + m_pBuffer[m_iDatLen++] = wch; + return true; } void Clear() { m_iDatPos = m_iDatLen = 0; } void Reset(); -- cgit v1.2.3