From a31d4a90f3446df76d8d3ffa0b441db0ad4623af Mon Sep 17 00:00:00 2001 From: thestig Date: Wed, 1 Jun 2016 20:18:41 -0700 Subject: Change CFX_Font::GetPsName() to return a CFX_ByteString. So everyone can avoid doing Byte to WideString conversions. Also remove CFX_GEFont::GetPsName() and deduplicate a couple of GetPsName() calls. Review-Url: https://codereview.chromium.org/2019173002 --- xfa/fgas/font/fgas_gefont.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'xfa/fgas/font/fgas_gefont.h') diff --git a/xfa/fgas/font/fgas_gefont.h b/xfa/fgas/font/fgas_gefont.h index aa072280d5..8667bf9b0a 100644 --- a/xfa/fgas/font/fgas_gefont.h +++ b/xfa/fgas/font/fgas_gefont.h @@ -19,8 +19,10 @@ class CXFA_PDFFontMgr; class CFX_GEFont : public IFX_Font { public: CFX_GEFont(const CFX_GEFont& src, uint32_t dwFontStyles); - CFX_GEFont(IFX_FontMgr* pFontMgr); + explicit CFX_GEFont(IFX_FontMgr* pFontMgr); ~CFX_GEFont(); + + // IFX_Font: virtual void Release(); virtual IFX_Font* Retain(); FX_BOOL LoadFont(const FX_WCHAR* pszFontFamily, @@ -32,7 +34,6 @@ class CFX_GEFont : public IFX_Font { FX_BOOL LoadFont(CFX_Font* pExtFont, FX_BOOL bTakeOver = FALSE); virtual IFX_Font* Derive(uint32_t dwFontStyles, uint16_t wCodePage = 0); virtual void GetFamilyName(CFX_WideString& wsFamily) const; - virtual void GetPsName(CFX_WideString& wsName) const; virtual uint32_t GetFontStyles() const; virtual uint8_t GetCharSet() const; virtual FX_BOOL GetCharWidth(FX_WCHAR wUnicode, -- cgit v1.2.3