From 524fa626d71efeb2164c82d565f17f077035b7df Mon Sep 17 00:00:00 2001
From: weili <weili@chromium.org>
Date: Mon, 23 May 2016 10:38:07 -0700
Subject: Clean up more XFA code which causes warnings

This is part of efforts to bring XFA to chromium_code standard.
Most of them will have behavior change.
The details of these problems are:

xfa/fgas/layout/fgas_rtfbreak.cpp:
  Wrong condition with misused variable
xfa/fgas/localization/fgas_locale.cpp
  Unnecessary condition
xfa/fxbarcode/datamatrix/BC_DataMatrixDecodedBitStreamParser.cpp
xfa/fxfa/app/xfa_fffield.cpp
  Unreachable code should be the correct code
xfa/fxbarcode/pdf417/BC_PDF417ScanningDecoder.cpp
xfa/fxbarcode/qrcode/BC_QRDetector.cpp
  Wrong condition logic

BUG=pdfium:29

Review-Url: https://codereview.chromium.org/2000073003
---
 xfa/fgas/localization/fgas_locale.cpp | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

(limited to 'xfa/fgas/localization/fgas_locale.cpp')

diff --git a/xfa/fgas/localization/fgas_locale.cpp b/xfa/fgas/localization/fgas_locale.cpp
index 6eed202643..f0d1066397 100644
--- a/xfa/fgas/localization/fgas_locale.cpp
+++ b/xfa/fgas/localization/fgas_locale.cpp
@@ -3655,9 +3655,8 @@ FX_BOOL FX_TimeFromCanonical(const CFX_WideStringC& wsTime,
             }
             millisecond = millisecond * 10 + str[cc++] - '0';
           }
-          if (cc < cc_start + 3 || millisecond >= 1000) {
+          if (cc < cc_start + 3)
             return FALSE;
-          }
         }
         if (cc < len) {
           FX_TIMEZONE tzDiff;
-- 
cgit v1.2.3