From 171cb27a720036c48ae3a6176084e880742af0a9 Mon Sep 17 00:00:00 2001 From: Dan Sinclair Date: Tue, 15 Aug 2017 09:43:07 -0400 Subject: Remove default params from xfa/fde code. This CL removes the default params from methods in xfa/fde. Change-Id: Ide93a51430c62753656b9e9c0bcd842d8179aa3c Reviewed-on: https://pdfium-review.googlesource.com/10952 Reviewed-by: Ryan Harrison Commit-Queue: dsinclair --- xfa/fgas/layout/cfx_txtbreak.cpp | 9 ++------- xfa/fgas/layout/cfx_txtbreak.h | 4 +--- 2 files changed, 3 insertions(+), 10 deletions(-) (limited to 'xfa/fgas') diff --git a/xfa/fgas/layout/cfx_txtbreak.cpp b/xfa/fgas/layout/cfx_txtbreak.cpp index 9e4e445e0a..b2c54e5c6d 100644 --- a/xfa/fgas/layout/cfx_txtbreak.cpp +++ b/xfa/fgas/layout/cfx_txtbreak.cpp @@ -634,9 +634,7 @@ struct FX_FORMCHAR { }; int32_t CFX_TxtBreak::GetDisplayPos(const FX_TXTRUN* pTxtRun, - FXTEXT_CHARPOS* pCharPos, - bool bCharCode, - CFX_WideString* pWSForms) const { + FXTEXT_CHARPOS* pCharPos) const { if (!pTxtRun || pTxtRun->iLength < 1) return 0; @@ -822,14 +820,11 @@ int32_t CFX_TxtBreak::GetDisplayPos(const FX_TXTRUN* pTxtRun, wLast = (wchar_t)formChars[j - 1].wForm; } if (!bEmptyChar || (bEmptyChar && !bSkipSpace)) { - pCharPos->m_GlyphIndex = - bCharCode ? wch : pFont->GetGlyphIndex(wForm, false); + pCharPos->m_GlyphIndex = pFont->GetGlyphIndex(wForm, false); #if _FXM_PLATFORM_ == _FXM_PLATFORM_APPLE_ pCharPos->m_ExtGID = pCharPos->m_GlyphIndex; #endif pCharPos->m_FontCharWidth = iCharWidth; - if (pWSForms) - *pWSForms += wForm; } int32_t iCharHeight = 1000; diff --git a/xfa/fgas/layout/cfx_txtbreak.h b/xfa/fgas/layout/cfx_txtbreak.h index 0529c2656c..d74ea350fe 100644 --- a/xfa/fgas/layout/cfx_txtbreak.h +++ b/xfa/fgas/layout/cfx_txtbreak.h @@ -66,9 +66,7 @@ class CFX_TxtBreak : public CFX_Break { CFX_BreakType EndBreak(CFX_BreakType dwStatus); int32_t GetDisplayPos(const FX_TXTRUN* pTxtRun, - FXTEXT_CHARPOS* pCharPos, - bool bCharCode = false, - CFX_WideString* pWSForms = nullptr) const; + FXTEXT_CHARPOS* pCharPos) const; std::vector GetCharRects(const FX_TXTRUN* pTxtRun, bool bCharBBox = false) const; CFX_BreakType AppendChar(wchar_t wch); -- cgit v1.2.3