From b3e7bfa6ed35651a22df314352883ccb44a7203d Mon Sep 17 00:00:00 2001 From: Dan Sinclair Date: Wed, 16 Aug 2017 16:37:16 -0400 Subject: Cleanup visibilty and unused methods in xfa/fde This CL fixes the visibility of some methods in xfa/fde along with removing unused methods. Unused params are also removed. Change-Id: Ic6e6d2ac8d07dc4bdabb3e0121831e4bf3fbb8ec Reviewed-on: https://pdfium-review.googlesource.com/11271 Reviewed-by: Henrique Nakashima Commit-Queue: dsinclair --- xfa/fwl/cfwl_edit.cpp | 22 +++++++++++++--------- 1 file changed, 13 insertions(+), 9 deletions(-) (limited to 'xfa/fwl/cfwl_edit.cpp') diff --git a/xfa/fwl/cfwl_edit.cpp b/xfa/fwl/cfwl_edit.cpp index 18fbd33b39..7dd8baded8 100644 --- a/xfa/fwl/cfwl_edit.cpp +++ b/xfa/fwl/cfwl_edit.cpp @@ -433,7 +433,7 @@ bool CFWL_Edit::OnPageLoad(int32_t nPageIndex) { if (!pPage) return false; - pPage->LoadPage(nullptr); + pPage->LoadPage(); return true; } @@ -442,7 +442,7 @@ bool CFWL_Edit::OnPageUnload(int32_t nPageIndex) { if (!pPage) return false; - pPage->UnloadPage(nullptr); + pPage->UnloadPage(); return true; } @@ -595,7 +595,12 @@ void CFWL_Edit::RenderText(CFX_RenderDevice* pRenderDev, if (!pTextSet) return; - CFX_RetainPtr pFont = pTextSet->GetFont(); + CFDE_TxtEdtEngine* engine = pPage.GetEngine(); + ASSERT(engine); + const FDE_TXTEDTPARAMS* params = engine->GetEditParams(); + ASSERT(params); + + CFX_RetainPtr pFont = params->pFont; if (!pFont) return; @@ -623,9 +628,8 @@ void CFWL_Edit::RenderText(CFX_RenderDevice* pRenderDev, char_pos.resize(iCount, FXTEXT_CHARPOS()); iCount = pTextSet->GetDisplayPos(pText, char_pos.data()); - CFDE_TextOut::DrawString(pRenderDev, pTextSet->GetFontColor(), pFont, - char_pos.data(), iCount, pTextSet->GetFontSize(), - &mt); + CFDE_TextOut::DrawString(pRenderDev, params->dwFontColor, pFont, + char_pos.data(), iCount, params->fFontSize, &mt); } } @@ -719,17 +723,17 @@ void CFWL_Edit::UpdateEditParams() { void CFWL_Edit::UpdateEditLayout() { if (m_EdtEngine.GetTextLength() <= 0) - m_EdtEngine.SetTextByStream(nullptr); + m_EdtEngine.SetText(L""); CFDE_TxtEdtPage* pPage = m_EdtEngine.GetPage(0); if (pPage) - pPage->UnloadPage(nullptr); + pPage->UnloadPage(); m_EdtEngine.Layout(); pPage = m_EdtEngine.GetPage(0); if (pPage) - pPage->LoadPage(nullptr); + pPage->LoadPage(); } bool CFWL_Edit::UpdateOffset() { -- cgit v1.2.3