From db194cf018069b930d0e3d5fc0242e14f70e8620 Mon Sep 17 00:00:00 2001 From: Dan Sinclair Date: Mon, 2 Jan 2017 15:45:12 -0500 Subject: Use return values in CFWL_Scrollbar instead of out params This CL updates CFWL_Scrollbar use return values instead of using out params. In some cases, the same values is assigned and passed in, but passing in the const ref is a lot clearer as to what is happening. Change-Id: Iff72a845e09ac73ff8eac938482547eaf251f835 Reviewed-on: https://pdfium-review.googlesource.com/2133 Reviewed-by: Tom Sepez Commit-Queue: dsinclair --- xfa/fwl/cfwl_scrollbar.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'xfa/fwl/cfwl_scrollbar.h') diff --git a/xfa/fwl/cfwl_scrollbar.h b/xfa/fwl/cfwl_scrollbar.h index 808975ed81..40beb7a3b9 100644 --- a/xfa/fwl/cfwl_scrollbar.h +++ b/xfa/fwl/cfwl_scrollbar.h @@ -79,11 +79,11 @@ class CFWL_ScrollBar : public CFWL_Widget { const CFX_Matrix* pMatrix); void Layout(); void CalcButtonLen(); - void CalcMinButtonRect(CFX_RectF& rect); - void CalcMaxButtonRect(CFX_RectF& rect); - void CalcThumbButtonRect(CFX_RectF& rect); - void CalcMinTrackRect(CFX_RectF& rect); - void CalcMaxTrackRect(CFX_RectF& rect); + CFX_RectF CalcMinButtonRect(); + CFX_RectF CalcMaxButtonRect(); + CFX_RectF CalcThumbButtonRect(const CFX_RectF& rtThumbRect); + CFX_RectF CalcMinTrackRect(const CFX_RectF& rtMinRect); + CFX_RectF CalcMaxTrackRect(const CFX_RectF& rtMaxRect); FX_FLOAT GetTrackPointPos(FX_FLOAT fx, FX_FLOAT fy); bool SendEvent(); -- cgit v1.2.3