From 4ce94e118d66064715de5baebeb4b2b580dcac66 Mon Sep 17 00:00:00 2001 From: weili Date: Sat, 18 Jun 2016 06:21:57 -0700 Subject: Make code compile with clang_use_chrome_plugin (part VI) This change mainly contains files in xfa/fwl directory. This is part of the efforts to make PDFium code compilable by Clang chromium style plugins. The changes are mainly the following: -- move inline constructor/destructor of complex class/struct out-of-line; -- add constructor/destructor of complex class/struct if not explicitly defined; -- add explicit out-of-line copy constructor when needed; -- move inline virtual functions out-of-line; -- Properly mark virtual functions with 'override'; -- some minor cleanups; BUG=pdfium:469 Review-Url: https://codereview.chromium.org/2070583003 --- xfa/fwl/core/ifwl_app.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'xfa/fwl/core/ifwl_app.h') diff --git a/xfa/fwl/core/ifwl_app.h b/xfa/fwl/core/ifwl_app.h index 5fbac6644f..27c65c8317 100644 --- a/xfa/fwl/core/ifwl_app.h +++ b/xfa/fwl/core/ifwl_app.h @@ -32,7 +32,7 @@ class IFWL_App { public: static IFWL_App* Create(CXFA_FFApp* pAdapter); - virtual ~IFWL_App() {} + virtual ~IFWL_App(); FWL_Error Initialize(); FWL_Error Finalize(); @@ -53,7 +53,7 @@ class IFWL_App { CFWL_NoteDriver* GetNoteDriver() const; private: - IFWL_App() {} + IFWL_App(); std::unique_ptr m_pImpl; }; -- cgit v1.2.3