From 29b8ad0b130ec6ed4f72ebd0c0a4f9e6a5b03467 Mon Sep 17 00:00:00 2001 From: weili Date: Tue, 14 Jun 2016 18:20:04 -0700 Subject: Make code compile with clang_use_chrome_plugin (part III) This change contains files in xfa/fxbarcode directory. This is part of the efforts to make PDFium code compilable by Clang chromium style plugins. The changes are mainly the following: -- move inline constructor/destructor of complex class/struct out-of-line; -- add constructor/destructor of complex class/struct if not explicitly defined; -- add explicit out-of-line copy constructor when needed; -- move inline virtual functions out-of-line; -- Properly mark virtual functions with 'override'; -- some minor cleanups; BUG=pdfium:469 Review-Url: https://codereview.chromium.org/2067903002 --- xfa/fxbarcode/cbc_upca.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'xfa/fxbarcode/cbc_upca.h') diff --git a/xfa/fxbarcode/cbc_upca.h b/xfa/fxbarcode/cbc_upca.h index a2e0658f39..cf45b89786 100644 --- a/xfa/fxbarcode/cbc_upca.h +++ b/xfa/fxbarcode/cbc_upca.h @@ -17,7 +17,7 @@ class CBC_UPCA : public CBC_OneCode { CBC_UPCA(); ~CBC_UPCA() override; - // CBC_OneCode: + // CBC_CodeBase FX_BOOL Encode(const CFX_WideStringC& contents, FX_BOOL isDevice, int32_t& e) override; @@ -30,7 +30,7 @@ class CBC_UPCA : public CBC_OneCode { int32_t height, int32_t& e) override; CFX_WideString Decode(CFX_DIBitmap* pBitmap, int32_t& e) override; - BC_TYPE GetType() override { return BC_UPCA; } + BC_TYPE GetType() override; private: CFX_WideString Preprocess(const CFX_WideStringC& contents); -- cgit v1.2.3