From 038aa531bcf1a76764d3cef46fd9b8e08b166dae Mon Sep 17 00:00:00 2001 From: weili Date: Fri, 20 May 2016 15:38:29 -0700 Subject: Clean up XFA code which causes warnings This is part of efforts to bring XFA to chromium_code standard. The warnings are from unreachable code, or using potentially uninitialized variables, or using assignment within a condition. This change list only contains easy to fix cases. More cleanups will follow. BUG=pdfium:29 Review-Url: https://codereview.chromium.org/1998873002 --- xfa/fxbarcode/oned/BC_OnedUPCAReader.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'xfa/fxbarcode/oned/BC_OnedUPCAReader.cpp') diff --git a/xfa/fxbarcode/oned/BC_OnedUPCAReader.cpp b/xfa/fxbarcode/oned/BC_OnedUPCAReader.cpp index 50a8fbb2f9..eb197b916c 100644 --- a/xfa/fxbarcode/oned/BC_OnedUPCAReader.cpp +++ b/xfa/fxbarcode/oned/BC_OnedUPCAReader.cpp @@ -89,9 +89,7 @@ CFX_ByteString CBC_OnedUPCAReader::MaybeReturnResult(CFX_ByteString& result, if (result[0] == '0') { result.Delete(0); return result; - } else { - e = BCExceptionFormatException; - return ""; } + e = BCExceptionFormatException; return ""; } -- cgit v1.2.3