From a9caab94c1f16929e5acf2676117224617d80f53 Mon Sep 17 00:00:00 2001 From: tsepez Date: Wed, 14 Dec 2016 05:57:10 -0800 Subject: Avoid the ptr.reset(new XXX()) anti-pattern Be suspicious of |new|. This removes some of the easy cases. Review-Url: https://codereview.chromium.org/2571913002 --- xfa/fxbarcode/pdf417/BC_PDF417.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'xfa/fxbarcode/pdf417/BC_PDF417.cpp') diff --git a/xfa/fxbarcode/pdf417/BC_PDF417.cpp b/xfa/fxbarcode/pdf417/BC_PDF417.cpp index 9d827acff6..9b8d0c149c 100644 --- a/xfa/fxbarcode/pdf417/BC_PDF417.cpp +++ b/xfa/fxbarcode/pdf417/BC_PDF417.cpp @@ -21,6 +21,8 @@ */ #include "xfa/fxbarcode/pdf417/BC_PDF417.h" + +#include "third_party/base/ptr_util.h" #include "xfa/fxbarcode/pdf417/BC_PDF417BarcodeMatrix.h" #include "xfa/fxbarcode/pdf417/BC_PDF417BarcodeRow.h" #include "xfa/fxbarcode/pdf417/BC_PDF417Compaction.h" @@ -432,7 +434,7 @@ void CBC_PDF417::generateBarcodeLogic(CFX_WideString msg, dataCodewords, errorCorrectionLevel, e); BC_EXCEPTION_CHECK_ReturnVoid(e); CFX_WideString fullCodewords = dataCodewords + ec; - m_barcodeMatrix.reset(new CBC_BarcodeMatrix(rows, cols)); + m_barcodeMatrix = pdfium::MakeUnique(rows, cols); encodeLowLevel(fullCodewords, cols, rows, errorCorrectionLevel, m_barcodeMatrix.get()); } -- cgit v1.2.3