From 29b8ad0b130ec6ed4f72ebd0c0a4f9e6a5b03467 Mon Sep 17 00:00:00 2001 From: weili Date: Tue, 14 Jun 2016 18:20:04 -0700 Subject: Make code compile with clang_use_chrome_plugin (part III) This change contains files in xfa/fxbarcode directory. This is part of the efforts to make PDFium code compilable by Clang chromium style plugins. The changes are mainly the following: -- move inline constructor/destructor of complex class/struct out-of-line; -- add constructor/destructor of complex class/struct if not explicitly defined; -- add explicit out-of-line copy constructor when needed; -- move inline virtual functions out-of-line; -- Properly mark virtual functions with 'override'; -- some minor cleanups; BUG=pdfium:469 Review-Url: https://codereview.chromium.org/2067903002 --- xfa/fxbarcode/qrcode/BC_QRCodeReader.h | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) (limited to 'xfa/fxbarcode/qrcode/BC_QRCodeReader.h') diff --git a/xfa/fxbarcode/qrcode/BC_QRCodeReader.h b/xfa/fxbarcode/qrcode/BC_QRCodeReader.h index c11ccd1f26..b3a72b4d18 100644 --- a/xfa/fxbarcode/qrcode/BC_QRCodeReader.h +++ b/xfa/fxbarcode/qrcode/BC_QRCodeReader.h @@ -22,7 +22,8 @@ class CBC_QRCodeReader : public CBC_Reader { public: CBC_QRCodeReader(); - virtual ~CBC_QRCodeReader(); + ~CBC_QRCodeReader() override; + CFX_ByteString Decode(CFX_DIBitmap* pBitmap, int32_t hints, int32_t byteModeDecode, @@ -32,8 +33,12 @@ class CBC_QRCodeReader : public CBC_Reader { int32_t byteModeDecode, int32_t& e); static void ReleaseAll(); - CFX_ByteString Decode(CBC_BinaryBitmap* image, int32_t hints, int32_t& e); - CFX_ByteString Decode(CBC_BinaryBitmap* image, int32_t& e); + + // CBC_Reader + CFX_ByteString Decode(CBC_BinaryBitmap* image, + int32_t hints, + int32_t& e) override; + CFX_ByteString Decode(CBC_BinaryBitmap* image, int32_t& e) override; virtual void Init(); }; -- cgit v1.2.3