From 5d9da0c1255a75dd9b7b2005f8b7d6ae4948feaf Mon Sep 17 00:00:00 2001 From: dsinclair Date: Thu, 21 Apr 2016 13:12:06 -0700 Subject: Remove CFWL_Note. This CL removes the CFWL_Note class. The two subclasses, CFWL_Event and CFWL_Message are distinct types and should not be related by the subclass. The code has been updated to pass the correct types as needed. The various FWL_EVTHASH and FWL_MSGHASH defines have all been removed and turned into an FWL_EventType and FWL_MessageType enum classes. BUG=pdfium:474 Review URL: https://codereview.chromium.org/1901183002 --- xfa/fxfa/app/xfa_ffchoicelist.cpp | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-) (limited to 'xfa/fxfa/app/xfa_ffchoicelist.cpp') diff --git a/xfa/fxfa/app/xfa_ffchoicelist.cpp b/xfa/fxfa/app/xfa_ffchoicelist.cpp index a13c36d973..cfd78c2035 100644 --- a/xfa/fxfa/app/xfa_ffchoicelist.cpp +++ b/xfa/fxfa/app/xfa_ffchoicelist.cpp @@ -185,14 +185,14 @@ int32_t CXFA_FFListBox::OnProcessMessage(CFWL_Message* pMessage) { } FWL_ERR CXFA_FFListBox::OnProcessEvent(CFWL_Event* pEvent) { CXFA_FFField::OnProcessEvent(pEvent); - uint32_t dwEventID = pEvent->GetClassID(); - switch (dwEventID) { - case FWL_EVTHASH_LTB_SelChanged: { + switch (pEvent->GetClassID()) { + case CFWL_EventType::SelectChanged: { CFX_Int32Array arrSels; OnSelectChanged(m_pNormalWidget->GetWidget(), arrSels); break; } - default: {} + default: + break; } return m_pOldDelegate->OnProcessEvent(pEvent); } @@ -498,33 +498,35 @@ void CXFA_FFComboBox::OnPostOpen(IFWL_Widget* pWidget) { int32_t CXFA_FFComboBox::OnProcessMessage(CFWL_Message* pMessage) { return m_pOldDelegate->OnProcessMessage(pMessage); } + FWL_ERR CXFA_FFComboBox::OnProcessEvent(CFWL_Event* pEvent) { CXFA_FFField::OnProcessEvent(pEvent); - uint32_t dwEventID = pEvent->GetClassID(); - switch (dwEventID) { - case FWL_EVTHASH_CMB_SelChanged: { + switch (pEvent->GetClassID()) { + case CFWL_EventType::SelectChanged: { CFWL_EvtCmbSelChanged* postEvent = (CFWL_EvtCmbSelChanged*)pEvent; OnSelectChanged(m_pNormalWidget->GetWidget(), postEvent->iArraySels, postEvent->bLButtonUp); break; } - case FWL_EVTHASH_CMB_EditChanged: { + case CFWL_EventType::EditChanged: { CFX_WideString wsChanged; OnTextChanged(m_pNormalWidget->GetWidget(), wsChanged); break; } - case FWL_EVTHASH_CMB_PreDropDown: { + case CFWL_EventType::PreDropDown: { OnPreOpen(m_pNormalWidget->GetWidget()); break; } - case FWL_EVTHASH_CMB_PostDropDown: { + case CFWL_EventType::PostDropDown: { OnPostOpen(m_pNormalWidget->GetWidget()); break; } - default: {} + default: + break; } return m_pOldDelegate->OnProcessEvent(pEvent); } + FWL_ERR CXFA_FFComboBox::OnDrawWidget(CFX_Graphics* pGraphics, const CFX_Matrix* pMatrix) { return m_pOldDelegate->OnDrawWidget(pGraphics, pMatrix); -- cgit v1.2.3