From cc4d6d85b58a7a1d9d7b798c63d3343f3dac06a9 Mon Sep 17 00:00:00 2001 From: tsepez Date: Mon, 16 May 2016 13:21:03 -0700 Subject: Remove { delete this; } anti-pattern from IXFA_WidgetIterator Review-Url: https://codereview.chromium.org/1976123003 --- xfa/fxfa/app/xfa_rendercontext.cpp | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'xfa/fxfa/app/xfa_rendercontext.cpp') diff --git a/xfa/fxfa/app/xfa_rendercontext.cpp b/xfa/fxfa/app/xfa_rendercontext.cpp index cc2ea4b9ac..e7bacec281 100644 --- a/xfa/fxfa/app/xfa_rendercontext.cpp +++ b/xfa/fxfa/app/xfa_rendercontext.cpp @@ -68,8 +68,6 @@ int32_t CXFA_RenderContext::DoRender(IFX_Pause* pPause) { return XFA_RENDERSTATUS_Done; } void CXFA_RenderContext::StopRender() { - if (m_pWidgetIterator) { - m_pWidgetIterator->Release(); - m_pWidgetIterator = NULL; - } + delete m_pWidgetIterator; + m_pWidgetIterator = nullptr; } -- cgit v1.2.3